Merged
Conversation
ming-Jo
approved these changes
Nov 12, 2025
Bori-github
commented
Nov 12, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a window menu system with native menu items and adds a dedicated Settings window accessible through the menu. Key changes include:
- Added native window menu with About, File, Edit, and View submenus
- Created a Settings window that opens when Settings menu item is clicked
- Implemented routing using react-router-dom to support multiple pages
- Added dynamic window title updates based on selected settings tab
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Updated dependencies, added react-router-dom and related packages |
| apps/executeJS/package.json | Added react-router-dom dependency |
| apps/executeJS/vite.config.ts | Added build configuration for SPA routing support |
| apps/executeJS/src/app/router.tsx | New router component defining routes for playground and settings |
| apps/executeJS/src/app/index.tsx | Updated to use Router instead of directly rendering PlaygroundPage |
| apps/executeJS/src/pages/settings/settings-page.tsx | New settings page with tabbed interface |
| apps/executeJS/src/pages/settings/index.ts | Export file for settings page |
| apps/executeJS/src-tauri/src/lib.rs | Added menu creation, event handling, and settings window logic |
| apps/executeJS/src-tauri/tauri.conf.json | Added capabilities configuration |
| apps/executeJS/src-tauri/capabilities/main.json | New capability file for window title permission |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- capabilities 파일 생성: src-tauri/capabilities/main.json 파일 생성 - 권한 추가: core:window:allow-set-title 권한 추가 - 설정 연결: tauri.conf.json에서 capabilities 파일 참조
Bori-github
force-pushed
the
feat/window-menu
branch
from
0cd9e3a to
d8c9388
Compare
ohah
pushed a commit
that referenced
this pull request
Dec 12, 2025
* feat: 타우리 window menu 기본 설정 * chore: react-router-dom 패키지 추가 * feat: window menu settings 클릭 시 새 window 창 생성 및 settings 페이지로 라우팅 처리 * feat: 설정 창을 위한 설정 페이지 생성 및 탭 선택 시 탭 제목 변경 기능 적용 * fix: window.set_title not allowed 권한 에러 수정을 위한 설정 추가 - capabilities 파일 생성: src-tauri/capabilities/main.json 파일 생성 - 권한 추가: core:window:allow-set-title 권한 추가 - 설정 연결: tauri.conf.json에서 capabilities 파일 참조 * fix: format rust * chore: 탭 클릭 시 getCurrentWindow 재호출 하지 않도록 처리 * chore: 불필요한 주석 제거 * chore: 잘못된 에러처리 수정 * fix: format rust
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 요약
📝 작업 내용
/settings페이지로 라우팅 처리되도록 적용🔍 스크린샷
window.menu.mov
💡 참고 사항